issue-489-and-491 #492

Merged

navicore merged 3 commits from issue-489-and-491 into main

2026-05-19 00:13:47 +00:00

navicore commented

2026-05-18 23:59:03 +00:00

Owner

#491

https://git.navicore.tech/navicore/patch-seq/issues/491

navicore added 2 commits

2026-05-18 23:59:03 +00:00

● fix applied: 36871a576e

- Cargo.toml: enabled unstable-rendered-line-info on ratatui so we can call Paragraph::line_count.
  - crates/repl/src/ui/repl_pane.rs: replaced the hand-rolled wrapped_height (which used ceil(chars/width) and was
   wrong whenever a single word overflowed a remaining-line gap) with paragraph.line_count(area.width). That asks
  ratatui's own WordWrapper for the exact display height, so the scroll math now matches what's actually rendered.

  The earlier Stdio::null() change in run.rs is a separate hardening — not the cause, but still a good thing to
  leave in (children running under the REPL should never share its raw-mode TTY). Let me know if you'd rather I
  revert that one; otherwise it stays.

  Try repeating your repro (ESC k ENTER on the keypair line, or the long-X-line spam) — the input prompt should
  now stay pinned above the bottom edge regardless of word length.

fix applied:

CI - Linux / CI - Linux x86_64 (pull_request) Failing after -4s

Details

4dbe9e9fc7

- Cargo.toml: enabled unstable-rendered-line-info on ratatui so we can call Paragraph::line_count.
  - crates/repl/src/ui/repl_pane.rs: replaced the hand-rolled wrapped_height (which used ceil(chars/width) and was
   wrong whenever a single word overflowed a remaining-line gap) with paragraph.line_count(area.width). That asks
  ratatui's own WordWrapper for the exact display height, so the scroll math now matches what's actually rendered.

  The earlier Stdio::null() change in run.rs is a separate hardening — not the cause, but still a good thing to
  leave in (children running under the REPL should never share its raw-mode TTY). Let me know if you'd rather I
  revert that one; otherwise it stays.

  Try repeating your repro (ESC k ENTER on the keypair line, or the long-X-line spam) — the input prompt should
  now stay pinned above the bottom edge regardless of word length.

navicore referenced this pull request

2026-05-18 23:59:30 +00:00

repl gets in bad state after keypair #491

navicore added 1 commit

2026-05-18 23:59:51 +00:00

fmt

CI - Linux / CI - Linux x86_64 (pull_request) Successful in 8m33s

Details

09872c6505

navicore merged commit 3bad5d0789 into main

2026-05-19 00:13:47 +00:00

navicore deleted branch issue-489-and-491