issue 435 #450

Merged

navicore merged 1 commit from test-disco into main

2026-05-03 22:53:23 +00:00

navicore commented

2026-05-03 22:35:14 +00:00

Owner

#435

Issue #435 reproducer: test-flag no longer crashes with stack underflow; runner reports test-real ... ok and a
clean diagnostic for the helper, with no ..rest noise.
Explicit non-test-.seq path: exits 2 with Test files must be named \test-.seq. Got: ... (was previously
silent zero).
Integration suite: still 501 passed, 0 failed — no real test silently demoted.
All 14 test_runner unit tests pass.
Full Rust workspace tests still green.

Files changed:

crates/compiler/src/test_runner.rs — is_unit_effect, format_effect_surface, validate_paths, SkippedTest,
signature-filtered discovery, skip diagnostic in print_results.
crates/compiler/src/test_runner/tests.rs — updated existing tests for new tuple, added 5 new tests.
crates/compiler/src/main/test.rs — calls validate_paths before run.
docs/design/TEST_DISCOVERY.md — design doc (still in docs/design/, not yet moved to done/ since you mentioned
earlier that implemented designs need first-class docs and we should decide where this lives —
STDLIB_REFERENCE/language-guide/TESTING_GUIDE).

https://git.navicore.tech/navicore/patch-seq/issues/435 - Issue #435 reproducer: test-flag no longer crashes with stack underflow; runner reports test-real ... ok and a clean diagnostic for the helper, with no ..rest noise. - Explicit non-test-*.seq path: exits 2 with Test files must be named \test-*.seq`. Got: ...` (was previously silent zero). - Integration suite: still 501 passed, 0 failed — no real test silently demoted. - All 14 test_runner unit tests pass. - Full Rust workspace tests still green. Files changed: - crates/compiler/src/test_runner.rs — is_unit_effect, format_effect_surface, validate_paths, SkippedTest, signature-filtered discovery, skip diagnostic in print_results. - crates/compiler/src/test_runner/tests.rs — updated existing tests for new tuple, added 5 new tests. - crates/compiler/src/main/test.rs — calls validate_paths before run. - docs/design/TEST_DISCOVERY.md — design doc (still in docs/design/, not yet moved to done/ since you mentioned earlier that implemented designs need first-class docs and we should decide where this lives — STDLIB_REFERENCE/language-guide/TESTING_GUIDE).

navicore added 1 commit

2026-05-03 22:35:14 +00:00

issue 435

CI - Linux / CI - Linux x86_64 (pull_request) Successful in 4m19s

Details

1ce2ed7ec1

- Issue #435 reproducer: test-flag no longer crashes with stack underflow; runner reports test-real ... ok and a
   clean diagnostic for the helper, with no ..rest noise.
  - Explicit non-test-*.seq path: exits 2 with Test files must be named \test-*.seq`. Got: ...` (was previously
  silent zero).
  - Integration suite: still 501 passed, 0 failed — no real test silently demoted.
  - All 14 test_runner unit tests pass.
  - Full Rust workspace tests still green.

  Files changed:
  - crates/compiler/src/test_runner.rs — is_unit_effect, format_effect_surface, validate_paths, SkippedTest,
  signature-filtered discovery, skip diagnostic in print_results.
  - crates/compiler/src/test_runner/tests.rs — updated existing tests for new tuple, added 5 new tests.
  - crates/compiler/src/main/test.rs — calls validate_paths before run.
  - docs/design/TEST_DISCOVERY.md — design doc (still in docs/design/, not yet moved to done/ since you mentioned
  earlier that implemented designs need first-class docs and we should decide where this lives —
  STDLIB_REFERENCE/language-guide/TESTING_GUIDE).

navicore referenced this pull request

2026-05-03 22:35:34 +00:00

Test discovery overloads the 'test-' prefix and conflicts with user word names #435

navicore merged commit f0c2a390e5 into main

2026-05-03 22:53:23 +00:00

navicore deleted branch test-disco

2026-05-03 22:53:23 +00:00

navicore referenced this pull request from a commit

2026-05-03 22:53:25 +00:00

Merge pull request 'issue 435' (#450) from test-disco into main