Group 1 validated. fmt clean, clippy clean, all 7 lexer tests pass. Non-test unwrap count: 4 → 0 (the 7 remaining #30

Open

navicore wants to merge 4 commits from code-audit-0626 into main

pull from: code-audit-0626

merge into: navicore:main

navicore:main

navicore:test-new-runner

Conversation 0 Commits 4 Files changed 3 +220 -235

navicore commented 2026-06-26 18:59:39 +00:00

Owner

Copy link

are all in #[cfg(test)]).

are all in #[cfg(test)]).

navicore added 1 commit 2026-06-26 18:59:39 +00:00

Group 1 validated. fmt clean, clippy clean, all 7 lexer tests pass. Non-test unwrap count: 4 → 0 (the 7 remaining ... 06e0066a86

are all in #[cfg(test)]).

navicore added 1 commit 2026-06-26 19:04:20 +00:00

Group 2 validated. fmt clean, clippy clean with no #[allow], all 7 lexer tests pass. ... d5eec27f91

Results:
 - next_token: 173 L → 35 L (thin dispatch)
 - new lex_operator: 90 L (under the 100 threshold, no suppression)
 - new binary_op (13 L) + single_char_token (15 L) — the dispatch-table finding 5 called for
 - #[allow(clippy::too_many_lines)] removed (finding 15 resolved)
 - File: 651 → 634 L

navicore added 1 commit 2026-06-26 22:45:33 +00:00

next group 1 6d0ebe2ced

navicore added 1 commit 2026-06-27 00:58:31 +00:00

next group 2 and 3 4fe0ecf855

All checks were successful

Hide all checks

CI - Linux / CI - Linux x86_64 (pull_request) Successful in 36s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin code-audit-0626:code-audit-0626

git switch code-audit-0626

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff code-audit-0626

git switch code-audit-0626

git rebase main

git switch main

git merge --ff-only code-audit-0626

git switch code-audit-0626

git rebase main

git switch main

git merge --no-ff code-audit-0626

git switch main

git merge --squash code-audit-0626

git switch main

git merge --ff-only code-audit-0626

git switch main

git merge code-audit-0626

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something isn't working

  

dependencies

Pull requests that update a dependency file

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

rust

Pull requests that update rust code

  

wontfix

This will not be worked on

No labels

bug

dependencies

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

rust

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

navicore/patch-rexx!30

No description provided.