⏺ just ci passes — "Safe to push - CI will pass." printed. The LSP diagnostics above #24

Merged
navicore merged 3 commits from ci into main 2026-05-22 01:05:58 +00:00
Owner

are stale (they show the pre-edit line); cargo test --all-targets ran cleanly
through the bench, so AssertUnwindSafe did its job.

Summary of what's in the working tree now:

New:

  • justfile — single source of truth, strict clippy preserved
  • rust-toolchain.toml — pins 1.95.0
  • .forgejo/workflows/ci-linux.yml — calls just ci, pinned 1.95.0

Deleted:

  • Makefile
  • .github/workflows/ci.yml
  • .github/workflows/rust-ci.yml

Modified:

  • README.md — Development section rewritten around just ci
  • src/completion_cache.rs:124 — .map(...).unwrap_or(0) → .map_or(0, ...)
  • src/string_pool.rs:61 — same
  • benches/benchmark.rs:341,350 — wrapped catch_unwind closures in AssertUnwindSafe

Untouched (kept as you previously decided): .github/workflows/release.yml,
.github/workflows/README.md, clippy.toml.

are stale (they show the pre-edit line); cargo test --all-targets ran cleanly through the bench, so AssertUnwindSafe did its job. Summary of what's in the working tree now: New: - justfile — single source of truth, strict clippy preserved - rust-toolchain.toml — pins 1.95.0 - .forgejo/workflows/ci-linux.yml — calls just ci, pinned 1.95.0 Deleted: - Makefile - .github/workflows/ci.yml - .github/workflows/rust-ci.yml Modified: - README.md — Development section rewritten around just ci - src/completion_cache.rs:124 — .map(...).unwrap_or(0) → .map_or(0, ...) - src/string_pool.rs:61 — same - benches/benchmark.rs:341,350 — wrapped catch_unwind closures in AssertUnwindSafe Untouched (kept as you previously decided): .github/workflows/release.yml, .github/workflows/README.md, clippy.toml.
are stale (they show the pre-edit line); cargo test --all-targets ran cleanly
  through the bench, so AssertUnwindSafe did its job.

  Summary of what's in the working tree now:

  New:
  - justfile — single source of truth, strict clippy preserved
  - rust-toolchain.toml — pins 1.95.0
  - .forgejo/workflows/ci-linux.yml — calls just ci, pinned 1.95.0

  Deleted:
  - Makefile
  - .github/workflows/ci.yml
  - .github/workflows/rust-ci.yml

  Modified:
  - README.md — Development section rewritten around just ci
  - src/completion_cache.rs:124 — .map(...).unwrap_or(0) → .map_or(0, ...)
  - src/string_pool.rs:61 — same
  - benches/benchmark.rs:341,350 — wrapped catch_unwind closures in AssertUnwindSafe

  Untouched (kept as you previously decided): .github/workflows/release.yml,
  .github/workflows/README.md, clippy.toml.
navicore-rust
Some checks failed
CI / just ci (pull_request) Failing after 6s
f6688433ba
⏺ Done. Now matches your sibling projects: no third-party action steps that act would
All checks were successful
CI - Linux / CI - Linux x86_64 (pull_request) Successful in 5s
5689dc757f
try to clone from data.forgejo.org, relying on the runner image at
  git.navicore.tech/navicore/navicore-forgejo-runner:latest for Rust + just. The
  verify step will fail loudly if the image ever drifts off 1.95.0.

  rust-toolchain.toml still pins 1.95.0 (matches the image by convention). The
  setup-rust-ci skill's invariant check was scoped to dtolnay/rust-toolchain@master
  steps, of which there are now zero — so it's vacuously satisfied.

  This is worth saving as memory so I don't repeat the mistake on your next Rust
  project.
Sign in to join this conversation.
No description provided.