clean up register optimize PR #302

New issue

Closed

opened 2026-01-25 17:01:38 +00:00 by navicore · 1 comment

navicore commented

2026-01-25 17:01:38 +00:00

(Migrated from github.com)

some clean up for later from PR https://github.com/navicore/patch-seq/pull/301

Add comment about integer overflow behavior at specialization.rs:774-796 explaining why nsw/nuw flags are omitted (intentional wrapping semantics)

Consider extracting shift bounds checking (specialization.rs:1186-1249) to a helper function to reduce duplication between left/right shifts

Float literal representation (specialization.rs:627-631) could use a comment explaining why bitcast is used for exact representation

some clean up for later from PR https://github.com/navicore/patch-seq/pull/301 Add comment about integer overflow behavior at specialization.rs:774-796 explaining why nsw/nuw flags are omitted (intentional wrapping semantics) Consider extracting shift bounds checking (specialization.rs:1186-1249) to a helper function to reduce duplication between left/right shifts Float literal representation (specialization.rs:627-631) could use a comment explaining why bitcast is used for exact representation

navicore commented

2026-01-25 18:28:03 +00:00

(Migrated from github.com)

https://github.com/navicore/patch-seq/pull/304